fix: include ignition data in package or save after 1st download #2591

spypsy · 2023-09-29T11:05:25Z

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

PhilWindle · 2023-10-04T07:42:16Z

yarn-project/deploy_npm.sh

-    jq --arg v $VERSION '.version = $v' package.json > $TMP && mv $TMP package.json
-
-    if [ -z "$STANDALONE" ]; then
+  REPOSITORY=$1


Has this file changed other than whitespace?

indeed no, will remove from PR

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.2</summary> ## [0.8.2](aztec-packages-v0.8.1...aztec-packages-v0.8.2) (2023-10-04) ### Features * Constrain return notes from oracle call. ([#2639](#2639)) ([248be1b](248be1b)) * Multiple pixies 1 Sandbox ([#2492](#2492)) ([572d572](572d572)) * Take an optional owner to create the initialization nullifier ([#2647](#2647)) ([fefc443](fefc443)) ### Bug Fixes * Add missing properties to deployed packages ([#2678](#2678)) ([343df30](343df30)) * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) * Removal of setting private data root in kernel prover ([#2671](#2671)) ([6a2cc28](6a2cc28)), closes [#778](#778) ### Miscellaneous * 1 deploy_dockerhub CI task ([#2670](#2670)) ([dff396c](dff396c)) * Check that portal address is saved ([#2641](#2641)) ([9ebef6e](9ebef6e)) * Fixes in deploy scripts ([#2659](#2659)) ([f44568b](f44568b)) * Measure circuit simulation times and input/output sizes ([#2663](#2663)) ([027f7ec](027f7ec)) * Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. ([#2645](#2645)) ([805fe18](805fe18)) </details> <details><summary>barretenberg.js: 0.8.2</summary> ## [0.8.2](barretenberg.js-v0.8.1...barretenberg.js-v0.8.2) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.2</summary> ## [0.8.2](barretenberg-v0.8.1...barretenberg-v0.8.2) (2023-10-04) ### Bug Fixes * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.2</summary> ## [0.8.2](AztecProtocol/aztec-packages@aztec-packages-v0.8.1...aztec-packages-v0.8.2) (2023-10-04) ### Features * Constrain return notes from oracle call. ([#2639](AztecProtocol/aztec-packages#2639)) ([248be1b](AztecProtocol/aztec-packages@248be1b)) * Multiple pixies 1 Sandbox ([#2492](AztecProtocol/aztec-packages#2492)) ([572d572](AztecProtocol/aztec-packages@572d572)) * Take an optional owner to create the initialization nullifier ([#2647](AztecProtocol/aztec-packages#2647)) ([fefc443](AztecProtocol/aztec-packages@fefc443)) ### Bug Fixes * Add missing properties to deployed packages ([#2678](AztecProtocol/aztec-packages#2678)) ([343df30](AztecProtocol/aztec-packages@343df30)) * Include ignition data in package or save after 1st download ([#2591](AztecProtocol/aztec-packages#2591)) ([d5e9f8b](AztecProtocol/aztec-packages@d5e9f8b)), closes [#2445](AztecProtocol/aztec-packages#2445) * Make target architecture configurable, target westmere in GA. ([#2660](AztecProtocol/aztec-packages#2660)) ([3cb9639](AztecProtocol/aztec-packages@3cb9639)) * Removal of setting private data root in kernel prover ([#2671](AztecProtocol/aztec-packages#2671)) ([6a2cc28](AztecProtocol/aztec-packages@6a2cc28)), closes [#778](AztecProtocol/aztec-packages#778) ### Miscellaneous * 1 deploy_dockerhub CI task ([#2670](AztecProtocol/aztec-packages#2670)) ([dff396c](AztecProtocol/aztec-packages@dff396c)) * Check that portal address is saved ([#2641](AztecProtocol/aztec-packages#2641)) ([9ebef6e](AztecProtocol/aztec-packages@9ebef6e)) * Fixes in deploy scripts ([#2659](AztecProtocol/aztec-packages#2659)) ([f44568b](AztecProtocol/aztec-packages@f44568b)) * Measure circuit simulation times and input/output sizes ([#2663](AztecProtocol/aztec-packages#2663)) ([027f7ec](AztecProtocol/aztec-packages@027f7ec)) * Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. ([#2645](AztecProtocol/aztec-packages#2645)) ([805fe18](AztecProtocol/aztec-packages@805fe18)) </details> <details><summary>barretenberg.js: 0.8.2</summary> ## [0.8.2](AztecProtocol/aztec-packages@barretenberg.js-v0.8.1...barretenberg.js-v0.8.2) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.2</summary> ## [0.8.2](AztecProtocol/aztec-packages@barretenberg-v0.8.1...barretenberg-v0.8.2) (2023-10-04) ### Bug Fixes * Include ignition data in package or save after 1st download ([#2591](AztecProtocol/aztec-packages#2591)) ([d5e9f8b](AztecProtocol/aztec-packages@d5e9f8b)), closes [#2445](AztecProtocol/aztec-packages#2445) * Make target architecture configurable, target westmere in GA. ([#2660](AztecProtocol/aztec-packages#2660)) ([3cb9639](AztecProtocol/aztec-packages@3cb9639)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Fixes #2445

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.2</summary> ## [0.8.2](aztec-packages-v0.8.1...aztec-packages-v0.8.2) (2023-10-04) ### Features * Constrain return notes from oracle call. ([#2639](#2639)) ([248be1b](248be1b)) * Multiple pixies 1 Sandbox ([#2492](#2492)) ([572d572](572d572)) * Take an optional owner to create the initialization nullifier ([#2647](#2647)) ([fefc443](fefc443)) ### Bug Fixes * Add missing properties to deployed packages ([#2678](#2678)) ([343df30](343df30)) * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) * Removal of setting private data root in kernel prover ([#2671](#2671)) ([6a2cc28](6a2cc28)), closes [#778](#778) ### Miscellaneous * 1 deploy_dockerhub CI task ([#2670](#2670)) ([dff396c](dff396c)) * Check that portal address is saved ([#2641](#2641)) ([9ebef6e](9ebef6e)) * Fixes in deploy scripts ([#2659](#2659)) ([f44568b](f44568b)) * Measure circuit simulation times and input/output sizes ([#2663](#2663)) ([027f7ec](027f7ec)) * Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. ([#2645](#2645)) ([805fe18](805fe18)) </details> <details><summary>barretenberg.js: 0.8.2</summary> ## [0.8.2](barretenberg.js-v0.8.1...barretenberg.js-v0.8.2) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.2</summary> ## [0.8.2](barretenberg-v0.8.1...barretenberg-v0.8.2) (2023-10-04) ### Bug Fixes * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

spypsy added 6 commits September 29, 2023 08:13

save ignition data on download

14a4071

Undo dev changes

edc4e0e

gud test (browser fix)

0e8e64e

use 'dirname' after 'isNode'

00758c5

fix paths

dd67a65

Offset options when reading downloaded file

2fca6a0

spypsy marked this pull request as draft October 2, 2023 17:08

spypsy added 2 commits October 2, 2023 17:24

Include ignition data in circuits.js npm package

1280b60

Move srs download to dockerfile

7bf65c0

spypsy changed the title ~~fix: save ignition data on 1st download~~ fix: include ignition data in package or save after 1st download Oct 3, 2023

spypsy marked this pull request as ready for review October 3, 2023 15:18

spypsy and others added 2 commits October 3, 2023 16:46

Merge branch 'master' into spy/save-ignition-data

12f5e01

fixes + add circuits.js gitignore

fef74bb

PhilWindle reviewed Oct 4, 2023

View reviewed changes

spypsy added 2 commits October 4, 2023 08:20

revert deploy_npm.sh changes

c511f74

revert EOF newline

4f23228

PhilWindle approved these changes Oct 4, 2023

View reviewed changes

spypsy merged commit d5e9f8b into master Oct 4, 2023
2 checks passed

spypsy deleted the spy/save-ignition-data branch October 4, 2023 12:01

AztecBot mentioned this pull request Oct 4, 2023

chore(master): Release 0.8.2 #2669

Merged

Maddiaa0 pushed a commit that referenced this pull request Oct 6, 2023

fix: include ignition data in package or save after 1st download (#2591)

a4f043b

Fixes #2445

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: include ignition data in package or save after 1st download #2591

fix: include ignition data in package or save after 1st download #2591

spypsy commented Sep 29, 2023

PhilWindle Oct 4, 2023

spypsy Oct 4, 2023

fix: include ignition data in package or save after 1st download #2591

fix: include ignition data in package or save after 1st download #2591

Conversation

spypsy commented Sep 29, 2023

Checklist:

PhilWindle Oct 4, 2023

Choose a reason for hiding this comment

spypsy Oct 4, 2023

Choose a reason for hiding this comment